-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix typos #45238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix typos #45238
Conversation
Thank you for your contribution @omahs! We will review the pull request and get back to you soon. |
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from /sdk/cosmos perspective. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieljurek @jairmyree - please double check why cspell didn't catch these.
@JimSuplizio please give this a quick 2nd review since it's updating some of your parts of contributing.md
[like] Jair Myree reacted to your message:
________________________________
From: Josh Free ***@***.***>
Sent: Friday, May 9, 2025 4:08:01 AM
To: Azure/azure-sdk-for-java ***@***.***>
Cc: Jair Myree ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/azure-sdk-for-java] Fix typos (PR #45238)
@joshfree approved this pull request.
@danieljurek<https://github.com/danieljurek> @jairmyree<https://github.com/jairmyree> - please double check why cspell didn't catch these.
@JimSuplizio<https://github.com/JimSuplizio> please give this a quick 2nd review since it's updating some of your parts of contributing.md
________________________________
In sdk/communication/azure-communication-callautomation/README.md<#45238 (comment)>:
@@ -98,7 +98,7 @@ If timeout was not set when calling "waitForEventProcessorAsync", the default ti
## Troubleshooting
-If you recieve a CommunicationErrorException with the messagae: "Action is invalid when call is not in Established state." This usually means the call has ended. This can occur if the participants all leave
+If you receive a CommunicationErrorException with the messagae: "Action is invalid when call is not in Established state." This usually means the call has ended. This can occur if the participants all leave
Message is still spelled wrong in the same line.
@danieljurek<https://github.com/danieljurek> @jairmyree<https://github.com/jairmyree> - is cspell not working properly at the moment?
________________________________
In sdk/communication/azure-communication-callingserver/README.md<#45238 (comment)>:
@@ -45,7 +45,7 @@ To be determined.
## Troubleshooting
…-If you recieve a CommunicationErrorException with the messagae: "Action is invalid when call is not in Established state." This usually means the call has ended. This can occur if the participants all leave
+If you receive a CommunicationErrorException with the messagae: "Action is invalid when call is not in Established state." This usually means the call has ended. This can occur if the participants all leave
Should be message
—
Reply to this email directly, view it on GitHub<#45238 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQC3WGF7F77GPAKEFJRULM325QS2DAVCNFSM6AAAAAB4TH5UN6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRWHEZTOOJQGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines