[Key Vault JCA] Included the org.brotli:dec library in the list of shaded dependencies to avoid issues when generating and publishing docs to MSLearn
#45395
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies to avoid issues when generating and publishing docs to MSLearn.
vcolin7
requested review from
alzimmermsft,
samvaity,
g2vinay,
JonathanGiles,
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
vcolin7
added
KeyVault
Client
There was a problem hiding this comment.
Pull Request Overview
Adds the org.brotli:dec library to the shaded dependencies to satisfy an internal docs-publishing tool.
- Added
org.brotli:decas an optional dependency in the POM. - Configured shading relocations and include rules for brotli in the Maven shade plugin.
- Updated external dependencies list and documented the change in the changelog.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/keyvault/azure-security-keyvault-jca/pom.xml | Added optional brotli dependency, shading relocation, and include |
| sdk/keyvault/azure-security-keyvault-jca/CHANGELOG.md | Documented inclusion of org.brotli:dec |
| eng/versioning/external_dependencies.txt | Registered org.brotli:dec;0.1.2 in external dependencies |
Comments suppressed due to low confidence (2)
sdk/keyvault/azure-security-keyvault-jca/pom.xml:282
- [nitpick] Consider adding or updating an integration test to verify that the brotli classes are correctly shaded and available at runtime for docs generation.
<include>org.brotli:dec:[0.1.2]</include>
sdk/keyvault/azure-security-keyvault-jca/pom.xml:46
- [nitpick] Align the indentation of the new
<dependency>block with the surrounding entries to maintain POM readability and consistency.
<dependency>
org.brotli:dec library in the list of shaded dependencies to avoid issues when generating and publishing docs to MSLearnorg.brotli:dec library in the list of shaded dependencies to avoid issues when generating and publishing docs to MSLearn
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we had an issue during the last release of the Key Vault JCA library where the step that publishes docs to MSLearn failed due to an internal tool expecting the library to include optional libraries some shaded code depends on. While not a fix, this should help as a workaround until said tool gets patched.