Improve the precommit hook #11107
Merged
Improve the precommit hook #11107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
daviwil,
sadasant,
xirzec,
willmtemple,
jeremymeng,
KarishmaGhiya,
HarshaNalluru,
ramya-rao-a,
joheredi and
richardpark-msft
sadasant
reviewed
Sep 8, 2020
| **/review/*.api.md | ||
| **/*.yml | ||
| **/*.yaml | ||
| **/*.d.ts |
There was a problem hiding this comment.
I'm also curious if this makes a difference
There was a problem hiding this comment.
pretty-quick applies the rules in .prettierignore file in a way different from prettier. The former applies the rules relative to the root of source control tree (see here) but the latter applies the rules relative to the ignore path (see here). It is confusing and there is an issue opened for it here: prettier/pretty-quick#95 (comment).
sadasant
reviewed
Sep 8, 2020
| "autoinstallerName": "rush-prettier", | ||
|
|
||
| // This will invoke common/autoinstallers/rush-prettier/node_modules/.bin/pretty-quick | ||
| "shellCommand": "pretty-quick --staged --no-restage" |
sadasant
approved these changes
Sep 8, 2020
xirzec
approved these changes
Sep 8, 2020
|
@ramya-rao-a I rebased your branch in this issue #10770 on this one and found the formatting changes applied to be reasonable: |
|
@ramya-rao-a can you confirm if this change is good for you? I'd love to get it into master soon. |
HarshaNalluru
approved these changes
Sep 10, 2020
This was referenced Sep 10, 2020
Merged
Merged
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Sep 10, 2020
* Create rush-prettier autoinstaller * Update the hook script to use rush command * do not restage formatted files * update .prettierignore to work with pretty-quick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
prettierwrapper is switched fromprecise-commitstopretty-quick. The main difference between the two is that the latter works on whole files instead of changed regions only, so no more bizarre formattings. Furthermore,.prettierignoreis picked up correctly and is used to filter out staged files that we do not want to runprettieron. Fixes Formatting issue with git hook #10770 and fixes [Prettier config] The precommit hook should pick up .prettierignore file #11077.Epic: #11105.