-
Notifications
You must be signed in to change notification settings - Fork 5k
Update TypeSpec emitter version to prerelease 1.0.0-alpha.20250926.2 #52883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the TypeSpec emitter version from alpha.20250926.1 to alpha.20250926.2, which is a prerelease dependency version bump for the Azure TypeSpec HTTP Client C# emitter package.
- Version bump of the @azure-typespec/http-client-csharp dependency to the latest alpha prerelease
Files not reviewed (1)
- eng/azure-typespec-http-client-csharp-emitter-package-lock.json: Language not supported
/// </param> | ||
/// <param name="voiceInternal"> | ||
/// supported voice identifiers and configurations. | ||
/// To assign an object to this property use . To assign an already formatted json string to this property use . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshLove-msft - well I didn't expect this to change. Do you know if we take preference of the custom type docs over the generated ones? This didn't look correct to begin with, but the updated summary doesn't look right either.
foreach (var item in prop.Value.EnumerateArray()) | ||
{ | ||
array.Add(new KeyVaultDataAction(item.GetString())); | ||
array.Add(KeyVaultDataAction.DeserializeKeyVaultDataAction(item, options)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgerangel-msft is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm not sure where this is coming from.. I will investigate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think this was caused by microsoft/typespec#8579. Will fix.
Generated by branded - http-client-csharp build 20250926.2
Triggered from branch: main