Updated emitter version #3034
Merged
Updated emitter version #3034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
KeyVault
heaths
requested changes
Sep 19, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure SDK for Key Vault
heaths
requested review from
weshaggard,
RickWinter,
vincenttran-msft,
jalauzon-msft and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the emitter version from 0.22.0 to 0.23.0 and reflects corresponding breaking changes in enum variant naming to align with Rust naming guidelines. The changes rename enum variants from UPPER_CASE to PascalCase format.
Key changes:
- Updated
@azure-tools/typespec-rustfrom 0.22.0 to 0.23.0 and@azure-tools/typespec-client-generator-corefrom 0.60.0 to 0.60.1 - Renamed enum variants to follow PascalCase convention (e.g.,
KeyType::RSA→KeyType::Rsa,EncryptionAlgorithm::RsaOAEP256→EncryptionAlgorithm::RsaOaep256) - Updated all test files and benchmarks to use the new enum variant names
Reviewed Changes
Copilot reviewed 6 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/emitter-package.json | Updated TypeSpec emitter versions |
| sdk/keyvault/azure_security_keyvault_keys/tests/key_client.rs | Updated enum variants in test cases |
| sdk/keyvault/azure_security_keyvault_keys/benches/benchmarks.rs | Updated enum variants in benchmark code |
| sdk/keyvault/azure_security_keyvault_keys/CHANGELOG.md | Documented breaking changes for enum variant renames |
| sdk/keyvault/azure_security_keyvault_certificates/tests/certificate_client.rs | Updated enum variants in certificate tests |
| sdk/keyvault/azure_security_keyvault_certificates/CHANGELOG.md | Documented breaking changes for enum variant renames |
Files not reviewed (1)
- eng/emitter-package-lock.json: Language not supported
heaths
approved these changes
Sep 20, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews azure_security_keyvault_certificates |
RickWinter
approved these changes
Sep 22, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Azure SDK for Key Vault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.