Skip to content

Conversation

@heaths
Copy link
Member

@heaths heaths commented Oct 9, 2025

Because typespec is just an implementation detail of core,
and to help simplify upcoming eng-sys changes that should make publishing easier,
move all the typespec crates under sdk/core.

@heaths heaths requested review from danieljurek and hallipr October 9, 2025 23:58
@github-actions github-actions bot added the Azure.Core The azure_core crate label Oct 9, 2025
@heaths
Copy link
Member Author

heaths commented Oct 10, 2025

@Hallir @danieljurek we talked about this a few days ago - that it should allow us to calculate the dependency order for all "core" crates. Do we want to move forward with this then? The sooner the better, because I have a few more core changes to make. It shouldn't affect anyway because we use workspace dependencies, and I did grep the repo (excluding target) for references to sdk/typespec. We'll also need to disable / archive the rust - typespec pipeline.

Because typespec is just an implementation detail of core,
and to help simplify upcoming eng-sys changes that should make publishing easier,
move all the typespec crates under sdk/core.
@heaths heaths marked this pull request as ready for review October 14, 2025 23:02
@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 23:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the typespec-related crates from sdk/typespec to sdk/core to reflect that typespec is an implementation detail of core and to simplify upcoming engineering system changes for publishing.

The key changes include:

  • Moving typespec crates from sdk/typespec/ to sdk/core/
  • Updating workspace configuration and CI pipeline definitions
  • Fixing documentation links to reflect the new locations

Reviewed Changes

Copilot reviewed 6 out of 78 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/typespec/ci.yml Removes the typespec-specific CI configuration file
sdk/core/typespec_macros/README.md Updates source code link to new location under sdk/core
sdk/core/typespec_client_core/CHANGELOG.md Updates README link to reflect new path location
sdk/core/ci.yml Adds typespec artifacts to core CI configuration
Cargo.toml Updates workspace member paths and dependency paths for typespec crates
.vscode/cspell.json Updates spell checker path pattern to match new location

@heaths heaths enabled auto-merge (squash) October 14, 2025 23:15
@heaths heaths merged commit 24b5ec1 into Azure:main Oct 14, 2025
21 checks passed
@heaths heaths deleted the move-typespec branch October 14, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core The azure_core crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants