Add ClientCertificateCredential tests #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
chlowell
requested review from
LarryOsterman,
RickWinter and
ronniegeraghty
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the ClientCertificateCredential class by implementing unit tests for authentication scenarios. The changes focus on testing success cases, error handling, and cloud configuration variations.
Key changes:
- Added a complete test module with three test functions covering different authentication scenarios
- Updated the
is_valid_requesthelper function to support optional assertion validation - Improved error handling in the main credential implementation with proper status code checking
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
client_certificate_credential.rs |
Added comprehensive test module and improved error handling with status code checking |
client_assertion_credential.rs |
Updated test helper function to support optional assertion validation |
workload_identity_credential.rs |
Updated test calls to match the modified helper function signature |
.vscode/cspell.json |
Added exclusion for .pfx certificate files to prevent spell checking |
|
@microsoft-github-policy-service rerun |
LarryOsterman
approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
heaths
requested changes
Oct 13, 2025
sdk/identity/azure_identity/src/client_certificate_credential.rs
Outdated
Show resolved
Hide resolved
heaths
approved these changes
Oct 14, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3126