Skip to content

Conversation

LarryOsterman
Copy link
Member

…ests

@LarryOsterman LarryOsterman marked this pull request as ready for review October 13, 2025 20:42
@LarryOsterman LarryOsterman requested a review from heaths as a code owner October 13, 2025 20:42
@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 20:42
@LarryOsterman LarryOsterman requested review from a team and RickWinter as code owners October 13, 2025 20:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive performance testing infrastructure to the Azure Key Vault crates. It introduces performance tests for both key and secret operations, along with CI/CD pipeline configurations for automated performance monitoring.

  • Adds performance test implementations for get_secret, get_key, and create_key operations
  • Creates Azure DevOps pipeline configuration files for automated performance testing
  • Updates documentation with detailed instructions for setting up performance pipelines

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/keyvault/azure_security_keyvault_secrets/tests/results.json Test results file for secret performance tests
sdk/keyvault/azure_security_keyvault_secrets/perf/get_secret.rs Modified get_secret performance test to make vault_url optional and use environment variables
sdk/keyvault/azure_security_keyvault_secrets/perf.yml New Azure DevOps pipeline configuration for secrets performance testing
sdk/keyvault/azure_security_keyvault_secrets/perf-tests.yml Test configuration file for secrets performance tests
sdk/keyvault/azure_security_keyvault_secrets/perf-resources.bicep Bicep template for provisioning Key Vault resources for performance testing
sdk/keyvault/azure_security_keyvault_keys/tests/results.json Test results file for key performance tests
sdk/keyvault/azure_security_keyvault_keys/perf/perf_tests.rs Main performance test runner for key operations
sdk/keyvault/azure_security_keyvault_keys/perf/get_key.rs Performance test implementation for getting keys
sdk/keyvault/azure_security_keyvault_keys/perf/create_key.rs Performance test implementation for creating keys
sdk/keyvault/azure_security_keyvault_keys/perf.yml Updated Azure DevOps pipeline configuration for keys performance testing
sdk/keyvault/azure_security_keyvault_keys/perf-tests.yml Removed sync arguments from key performance test configuration
sdk/keyvault/azure_security_keyvault_keys/Cargo.toml Added performance test configuration to Cargo.toml
sdk/core/azure_core_test/src/perf/README.md Updated documentation with comprehensive pipeline setup instructions

@LarryOsterman LarryOsterman linked an issue Oct 13, 2025 that may be closed by this pull request
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some open questions of concern, but also seems some files were checked in that shouldn't be (and I'll have to review again anyway).

Overall, LGTM.

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure SDK for Key Vault Oct 14, 2025
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the azure_core benchmarks were fine. Probably just one function wasn't worth keeping, but the others were.

@heaths
Copy link
Member

heaths commented Oct 14, 2025

Besides, you'd have needed to fix azure_core's Cargo.toml to remove the benches, but I think put them back. At best, remove the HTTP rest from benchmarks but leave the rest. I updated it in #3190

@LarryOsterman LarryOsterman merged commit 7e17930 into Azure:main Oct 15, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure SDK for Key Vault Oct 15, 2025
@LarryOsterman LarryOsterman deleted the larryo/tweak_perf_pipeline branch October 15, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core The azure_core crate KeyVault Key Vault

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Documentation for performance tests.

2 participants