-
Notifications
You must be signed in to change notification settings - Fork 314
Finish readme text on pipeline provisioning; added keyvault secrets t… #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish readme text on pipeline provisioning; added keyvault secrets t… #3186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive performance testing infrastructure to the Azure Key Vault crates. It introduces performance tests for both key and secret operations, along with CI/CD pipeline configurations for automated performance monitoring.
- Adds performance test implementations for get_secret, get_key, and create_key operations
- Creates Azure DevOps pipeline configuration files for automated performance testing
- Updates documentation with detailed instructions for setting up performance pipelines
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
sdk/keyvault/azure_security_keyvault_secrets/tests/results.json |
Test results file for secret performance tests |
sdk/keyvault/azure_security_keyvault_secrets/perf/get_secret.rs |
Modified get_secret performance test to make vault_url optional and use environment variables |
sdk/keyvault/azure_security_keyvault_secrets/perf.yml |
New Azure DevOps pipeline configuration for secrets performance testing |
sdk/keyvault/azure_security_keyvault_secrets/perf-tests.yml |
Test configuration file for secrets performance tests |
sdk/keyvault/azure_security_keyvault_secrets/perf-resources.bicep |
Bicep template for provisioning Key Vault resources for performance testing |
sdk/keyvault/azure_security_keyvault_keys/tests/results.json |
Test results file for key performance tests |
sdk/keyvault/azure_security_keyvault_keys/perf/perf_tests.rs |
Main performance test runner for key operations |
sdk/keyvault/azure_security_keyvault_keys/perf/get_key.rs |
Performance test implementation for getting keys |
sdk/keyvault/azure_security_keyvault_keys/perf/create_key.rs |
Performance test implementation for creating keys |
sdk/keyvault/azure_security_keyvault_keys/perf.yml |
Updated Azure DevOps pipeline configuration for keys performance testing |
sdk/keyvault/azure_security_keyvault_keys/perf-tests.yml |
Removed sync arguments from key performance test configuration |
sdk/keyvault/azure_security_keyvault_keys/Cargo.toml |
Added performance test configuration to Cargo.toml |
sdk/core/azure_core_test/src/perf/README.md |
Updated documentation with comprehensive pipeline setup instructions |
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some open questions of concern, but also seems some files were checked in that shouldn't be (and I'll have to review again anyway).
Overall, LGTM.
sdk/keyvault/azure_security_keyvault_keys/benches/benchmarks.rs
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure_security_keyvault_secrets/tests/results.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the azure_core benchmarks were fine. Probably just one function wasn't worth keeping, but the others were.
Besides, you'd have needed to fix |
…ests