-
Notifications
You must be signed in to change notification settings - Fork 313
Sync eng/common directory with azure-sdk-tools for PR 12483 #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azure-sdk
wants to merge
9
commits into
main
Choose a base branch
from
sync-eng/common-copilot/create-upgrade-pr-on-failure-12483
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync eng/common directory with azure-sdk-tools for PR 12483 #3193
azure-sdk
wants to merge
9
commits into
main
from
sync-eng/common-copilot/create-upgrade-pr-on-failure-12483
+42
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools repository to incorporate improvements to the TypeSpec emitter pipeline template. The changes enhance PR creation logic with better naming, conditional execution, and improved draft handling.
Key changes:
- Added emitterIdentifier variable support for dynamic PR titles
- Improved PR draft creation logic based on generation job results
- Enhanced conditional execution for the Create PR job
ab33ccc
to
9a95a0b
Compare
weshaggard
approved these changes
Oct 14, 2025
6d2e340
to
357ebc8
Compare
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
357ebc8
to
fc4cf90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Central-EngSys
This issue is owned by the Engineering System team.
EngSys
This issue is impacting the engineering system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12483 See eng/common workflow