Enable configuring retryable status codes #3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
requested review from
LarryOsterman,
RickWinter and
heaths
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to configure which HTTP status codes should trigger retries in the retry policy. Previously, retries were attempted for a fixed set of status codes. Now, users can customize this list through a new with_retry_statuses() builder method on RetryOptions.
Key changes:
- Adds a new
get_retry_status_codes()method to theRetryPolicytrait - Implements configurable status codes in both
FixedRetryPolicyandExponentialRetryPolicy - Provides a fluent builder API through
RetryOptions::with_retry_statuses()
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/typespec_client_core/src/http/policies/retry/mod.rs | Adds get_retry_status_codes() to RetryPolicy trait, renames constant to DEFAULT_RETRY_STATUSES, updates retry logic, adds comprehensive tests |
| sdk/core/typespec_client_core/src/http/policies/retry/fixed.rs | Implements configurable status codes in FixedRetryPolicy with new field and getter method |
| sdk/core/typespec_client_core/src/http/policies/retry/exponential.rs | Implements configurable status codes in ExponentialRetryPolicy with new field and getter method |
| sdk/core/typespec_client_core/src/http/options/retry.rs | Adds with_retry_statuses() builder method and status_codes field to RetryOptions |
| sdk/core/typespec_client_core/CHANGELOG.md | Documents the new feature in the changelog |
LarryOsterman
approved these changes
Oct 23, 2025
heaths
requested changes
Oct 25, 2025
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
Given your description, I don't think this is the right place to define these.
chlowell
force-pushed
the
retry-status-codes
branch
from
5141cbc to
06118a8
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
heaths
requested changes
Nov 3, 2025
sdk/core/typespec_client_core/src/http/policies/retry/exponential.rs
Outdated
Show resolved
Hide resolved
sdk/core/typespec_client_core/src/http/policies/retry/exponential.rs
Outdated
Show resolved
Hide resolved
heaths
approved these changes
Nov 4, 2025
LarryOsterman
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this feature won't often be used, however I know a couple uses of it with the Go SDK and
azure_identityneeds either this or a custom retry policy to implement correct behavior for IMDS.