Sync eng/common directory with azure-sdk-tools for PR 12734 #3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cspell package configuration to use a scoped package name and pins the cspell dependency to an exact version. The changes improve dependency management by removing the version range specifier and making the package private.
Key changes:
- Renamed package from
cspell-version-pinto@azure-tools/cspell - Changed cspell dependency from
^9.2.1to exact version9.2.1 - Added
"private": trueto package.json
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updated package name to scoped @azure-tools/cspell, added private flag, and pinned cspell to exact version |
| eng/common/spelling/package-lock.json | Synchronized lockfile with package.json changes for name and version pinning |
Files not reviewed (1)
- eng/common/spelling/package-lock.json: Language not supported
| { | ||
| "name": "cspell-version-pin", | ||
| "name": "@azure-tools/cspell", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
The version field in package-lock.json should match the version in package.json. However, package.json no longer includes an explicit version field after adding "private": true. For private packages, it's recommended to either keep the version field in package.json for consistency or remove it from package-lock.json as well.
Suggested change
| "version": "1.0.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow