Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the signed-resource requirement for account SAS tokens #396

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Removing the signed-resource requirement for account SAS tokens #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbdd3fa
upgrade recommended cpprest version to 2.10.18 (#380)
Jinming-Hu Feb 23, 2021
95ce93f
removing the signed-resource requirement for account SAS tokens
toswedlu Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Microsoft.WindowsAzure.Storage/src/shared_access_signature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,6 @@ namespace azure { namespace storage { namespace protocol {
splitted_query.erase(remove_param);
}

auto signed_resource = splitted_query.find(protocol::uri_query_sas_resource);
if (require_signed_resource && signed_resource == splitted_query.end())
{
throw std::invalid_argument(protocol::error_missing_params_for_sas);
}

web::http::uri_builder builder;
for (auto iter = splitted_query.cbegin(); iter != splitted_query.cend(); ++iter)
{
Expand Down
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ To build with source code, there are three ways to install dependencies:
Because Casablanca does not release NuGet packages anywhere anymore, Starting from 5.1.0, this repository cannot be built with pre-built Casablanca NuGet packages. However, you can export your own version of Casablanca NuGet packages to install dependencies of this project:
```BatchFile
C:\src\vcpkg> .\vcpkg install cpprestsdk
C:\src\vcpkg> .\vcpkg export --nuget cpprestsdk --nuget-id=Casablanca --nuget-version=2.10.16
C:\src\vcpkg> .\vcpkg export --nuget cpprestsdk --nuget-id=Casablanca --nuget-version=2.10.18
```

- Manage dependencies by yourself
Expand Down Expand Up @@ -131,7 +131,7 @@ The validated Casablanca version for each major or recent release on different p
| 7.3.0 | 2.10.15 | 2.10.15 |
| 7.3.1 | 2.10.15 | 2.10.15 |
| 7.4.0 | 2.10.16 | 2.10.16 |
| 7.5.0 | 2.10.16 | 2.10.16 |
| 7.5.0 | 2.10.18 | 2.10.18 |

## Code Samples

Expand Down Expand Up @@ -226,7 +226,7 @@ git clone https://github.com/Microsoft/cpprestsdk.git

- Checkout the version on which Azure Storage Client Library for C++ depends:
```bash
git checkout tags/v2.10.16 -b v2.10.16
git checkout tags/v2.10.18 -b v2.10.18
```

- Build the project in Release mode
Expand Down Expand Up @@ -334,7 +334,7 @@ git clone https://github.com/Microsoft/cpprestsdk.git
- Checkout the version on which Azure Storage Client Library for C++ depends:
```bash
cd cpprestsdk
git checkout tags/v2.10.16 -b v2.10.16
git checkout tags/v2.10.18 -b v2.10.18
```

- Build the project in Release mode
Expand Down