Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against nil value for x-ms-blob-content-type #212

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

sethboyles
Copy link

@sethboyles sethboyles commented Feb 10, 2022

This PR just adds usage of StorageService.with_header for x-ms-content-type, so it behaves the same as other headers.

Without this, we are having issue correctly generating the authorization signature:

AuthenticationFailed", @description: "Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.\nRequestId:3b52e87a-d01e-000a-58ac-1e4d7a000000\nTime:2022-02-10T18:35:24.3205083Z">

@sethboyles
Copy link
Author

@katmsft apologies if I am tagging the wrong person. Is it possible to get this merged & released at some point? It is blocking us from getting https://github.com/fog/fog-azure-rm/ upgraded to the newer versions of azure-storage-ruby.

Thanks

@MerricdeLauney
Copy link

Hi @katmsft, Just checking in on this.

@sethboyles
Copy link
Author

@yaxia @katmsft Could we get this looked at?

@yaxia yaxia changed the base branch from master to dev July 15, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants