Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure implicit extensions are output #16250

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Ensure implicit extensions are output #16250

merged 1 commit into from
Jan 31, 2025

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jan 31, 2025

Closes #15396

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Test this change out locally with the following install scripts (Action run 13078641807)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13078641807
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13078641807"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13078641807
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13078641807"

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   32m 36s ⏱️ - 15m 3s
11 711 tests  -     12  11 711 ✅  -     12  0 💤 ±0  0 ❌ ±0 
27 180 runs   - 13 582  27 180 ✅  - 13 582  0 💤 ±0  0 ❌ ±0 

Results for commit 935301a. ± Comparison against base commit 497f9c9.

This pull request removes 1787 and adds 612 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Ա
�0\u0010\u0006��>E�\u0001�\����"��\u0000ўX���\u0015
⻛\u000e���R[�|cr�K�?"��fM6��\u0012�h\u0019\u000864�\u0018�;�[��\u0001�H&1�\u0014c�\u0019��\u000e����ke��~����ӌV�a\u001c*4�\u0002�D@���\u001d��`�\u000b[�Vi�P#��5o˳����x��{O�)�2���\u0001\u001aA��\u0011�&2.�|�L�y��|�˩)�PS��lO�|ɏ�R�c��<���y\u0002]	3	\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K\u000e�0\u0010\u0006�=\u0005'(�2��\u0005{�^�Q\u0012\u001f�\u0018\u001e��xw���\u0005�
�����L:�������\u001e����P�R�My�8z>\u0000\u0003\u0002�E	�\u0006�\u0010Q?�$#����\u001fe��~�N#۞�"\u0007N�D3Q&�3��7����At��1���U7'�M円r�a�\u0006����[+�����\u0000dd�\u0004���\u0003j��E2����?֞ \u0008� X�\u0013�9m�\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
���\u000b�0\u0014\u0007��+����/�4�\u0010t�\u0008\u000b��1R�@\u000b5\u0010�盇�tQ\u000b��=����\u0011w��U����\u0008W��\u0004
�\u001aJ���\u0016��\u0018�PD��8B�\u0019��\u000e��֥ie��~\u0010����<
\u0019\u0008_pP��\u0007�\u0010����S�\u001e\u000b�M��0+��!��Z��y_���i�x��xO�)��Kdf�\u0004&\u0005S����#�$�����\u0013Ň�&Z\u001e��m�̱����ɲ,�\u001a�\u00136r\u0004/\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ
�0\u0010\u0000��>E�\u0003��\zU� 8X�*\u0008�\u0012l�
��V(�\uda58\udcf8X\Z\u0015�7���]\u0008wt�����Ԕ\u0015�\u00008��o�
\u0000^޷8 ���\u0008C\u00150B���N^�V�.m+����D��:�M�Q�R�BE�I�\u0002F6v��w��1ʊ�4�T��6=�J��3�\u000e��\u001b�ƻ�g\u0002��\u0001�\u001c$\u0013HX������������q�����~�]'�Գ\u001b��=9��8û\u0003;�\u001d�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ
�0\u0010\u0007��>E�\u0001�IzUpw\u0011\|�؞��*M�������\u000f0�1���\u0010.b��͂lA�\u0013Jk�\u000864\u0008R�;�[R#��\u0000\u000cФ�\u0018o\u0006����y[�Q>��\u0007%\u0019�~_�\��T�\u0006��L\u0001��(�\udab9\ude9c�����*�\u0011\u0007w��x�\u0017��5�\u001e��{_�W�\u000fJ��\u0007h�ZA�\u000cRcB��d'�|��|���9S�XR��z<�[{tt��lQ\u0014E���\u0001/=z�\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003���
�0\u000c\u0007��\u0014>AM�t����^�l�>�\u000e�L\u0018{���`\u0007e\u0017���wl\u0008I	���l_��P6��D�J17\u0008�D��\u00034(�_@\u0000\u001b��H��7\u0019ѵ�6a�%f� �%֟�2G֙Vl�H@R�j\u0013j��\u001a&W�y�.��9ynk74TS
k�4\u001a�~�o����\u0000%��\u0018I����\u001c�H&�<����\u001bDQ\u0014Ekx\u0002�Q��\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createObject('key', 'value')","object","{
  key: 'value'
}")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\n")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\r\n")
…

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin merged commit 28c3d18 into main Jan 31, 2025
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue15396 branch January 31, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import aliases from bicepconfig.json are not used in JSON generation
2 participants