Skip to content

Commit

Permalink
Fix bug where new captions dismiss reaction flyout (#4707)
Browse files Browse the repository at this point in the history
* reaction flyout dismiss

* Change files
  • Loading branch information
carocao-msft authored Jun 7, 2024
1 parent 1779c88 commit 5a86173
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Reactions",
"comment": "Fixed bug where reactions is dismissed when receiving new captions",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Reactions",
"comment": "Fixed bug where reactions is dismissed when receiving new captions",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/react-components/src/components/ReactionButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { emojiStyles, reactionEmojiMenuStyles, reactionToolTipHostStyle } from '
import { isDarkThemed } from '../theming/themeUtils';
import { ReactionResources } from '..';
import { getEmojiFrameCount } from './VideoGallery/utils/videoGalleryLayoutUtils';
import { _preventDismissOnEvent } from '@internal/acs-ui-common';

/**
* Props for {@link ReactionButton}.
Expand Down Expand Up @@ -151,7 +152,8 @@ export const ReactionButton = (props: ReactionButtonProps): JSX.Element => {
className={mergeStyles(styles, props.styles)}
menuProps={{
shouldFocusOnMount: true,
items: emojiList
items: emojiList,
calloutProps: { preventDismissOnEvent: _preventDismissOnEvent }
}}
onRenderIcon={props.onRenderIcon ?? onRenderIcon}
strings={strings}
Expand Down

0 comments on commit 5a86173

Please sign in to comment.