Skip to content

Commit

Permalink
Fixed a script for release branch creation(#3444)
Browse files Browse the repository at this point in the history
  • Loading branch information
vhuseinova-msft authored Aug 14, 2023
1 parent 0f5b552 commit 8c3ecc6
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/create-prerelease-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
if: ${{ github.event.inputs.bump_type == 'beta-release-major' || github.event.inputs.bump_type == 'beta-release-minor' || github.event.inputs.bump_type == 'beta-release-patch' || github.event.inputs.bump_type == 'beta-release-beta' }}
run: node common/scripts/changelog/collect.mjs beta
- name: Generate stable CHANGELOG
if: ${{ github.event.inputs.bump_type == 'stable-major' || github.event.inputs.bump_type == 'stable-minor' || github.event.inputs.bump_type == 'stable-patch' }}
if: ${{ github.event.inputs.bump_type == 'stable-major' || github.event.inputs.bump_type == 'stable-minor' || github.event.inputs.bump_type == 'stable-patch' || github.event.inputs.bump_type == 'stable-remove-beta-version' }}
run: node common/scripts/changelog/collect.mjs stable

- name: sanity check - ensure all package versions are consistent
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-release-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ jobs:
# e.g. https://github.com/Azure/communication-ui-library/pull/2441 was needed to unbreak CI
# on a stable release branch.
- name: Force build flavor to `stable`
if: ${{ startsWith(github.event.inputs.branch, 'prerelease-stable-minor') || startsWith(github.event.inputs.branch, 'prerelease-stable-patch')}}
if: ${{ startsWith(github.event.inputs.branch, 'prerelease-stable') }}
run: |
node ./common/scripts/force-build-flavor.mjs stable
rush update
- name: Force build flavor to `beta-release`
if: ${{ startsWith(github.event.inputs.branch, 'prerelease-beta' )}}
if: ${{ startsWith(github.event.inputs.branch, 'prerelease-beta') }}
run: node ./common/scripts/force-build-flavor.mjs beta-release

# Synchronize the telemetry package versions.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
"area": "improvement",
"workstream": "CI",
"comment": "Fixed a script for release branch creation",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
"area": "improvement",
"workstream": "CI",
"comment": "Fixed a script for release branch creation",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion docs/releases/creating-a-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ This section describes what the workflow above does. Understanding the workflow
1. Create a Pull Request to merge the prerelease branch back into the base branch.
1. For stable release only: Before creating the Pull Request, @azure/communiation-react will be version bumped once again to a `-beta.0` version (this ensures that we can continue to add changes of `prerelease`) type.
1. Create a new release branch off of the prerelease branch. This branch will be used for the eventual release, but **it will never be merged back in the base branch**.
1. On the release branch will check what kind of release this is, beta, stable-minor, or stable-patch. based on the selection here it will update the sdk versions.
1. On the release branch will check what kind of release this is, beta-release-major, beta-release-minor, beta-release-patch , beta-release-beta, stable-major, stable-minor, stable-patch or stable-remove-beta-version based on the selection here it will update the sdk versions.
2. The action will synchronize the package telemetry verions on the release branch.
3. After making these changes it will make a PR from the pre-release branch back into `main`.

Expand Down

0 comments on commit 8c3ecc6

Please sign in to comment.