Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stablize Notifications Feature #4860

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Stablize Notifications Feature #4860

merged 6 commits into from
Jul 12, 2024

Conversation

carocao-msft
Copy link
Contributor

What

Stablize Notifications Feature

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft requested review from a team as code owners July 12, 2024 22:42
@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-mjukvrjvnx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

Calling bundle size is increased❗.

  • Current size: 5086535
  • Base size: 5086534
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 2108152
  • Base size: 2108151
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6441999
  • Base size: 6441998
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qxuorlshju.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@carocao-msft carocao-msft added breaking-change update_snapshots Set this label to request automated update of UI snapshots labels Jul 12, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-qrqluevtom.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-znhqtkdqal.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-rcgozlmjpb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mngdrzkbpo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-uuupgjlovf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kdojmsageq.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26551 / 41785
63.54%		 26551 / 41785
63.54%		 719 / 1297
55.43%		 2118 / 3350
63.22%
Current 26573 / 42042
63.2%		 26573 / 42042
63.2%		 719 / 1297
55.43%		 2099 / 3339
62.86%
Diff 22 / 257
-0.34%		 22 / 257
-0.34%		 0 / 0
0%		 -19 / -11
-0.36%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 52504 / 84504
62.13%		 52504 / 84504
62.13%		 1065 / 2366
45.01%		 3130 / 5127
61.04%
Current 52458 / 84504
62.07%		 52458 / 84504
62.07%		 1065 / 2366
45.01%		 3008 / 5057
59.48%
Diff -46 / 0
-0.06%		 -46 / 0
-0.06%		 0 / 0
0%		 -122 / -70
-1.56%

@carocao-msft carocao-msft merged commit 463abe1 into main Jul 12, 2024
42 checks passed
@carocao-msft carocao-msft deleted the carocao/notificationsStable branch July 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@dmceachernmsft dmceachernmsft

@edwardlee-msft edwardlee-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carocao-msft @dmceachernmsft @edwardlee-msft