Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RTE toggle visual state to default to checked. #5291

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

palatter
Copy link
Member

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@palatter palatter requested review from a team as code owners October 10, 2024 15:39
@palatter palatter added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Oct 10, 2024
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11750180
  • Base size: 11750180
  • Diff size: 0

Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1756786
  • Base size: 1756768
  • Diff size: 18

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11750193
  • Base size: 11750193
  • Diff size: 0

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26670 / 42998
62.02%
26670 / 42998
62.02%
729 / 1332
54.72%
2123 / 3399
62.45%
Current 26723 / 42998
62.14%
26723 / 42998
62.14%
729 / 1332
54.72%
2110 / 3400
62.05%
Diff 53 / 0
0.12%
53 / 0
0.12%
0 / 0
0%
-13 / 1
-0.4%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54050 / 88314
61.2%
54050 / 88314
61.2%
1096 / 2484
44.12%
3202 / 5294
60.48%
Current 54080 / 88315
61.23%
54080 / 88315
61.23%
1096 / 2484
44.12%
3194 / 5288
60.4%
Diff 30 / 1
0.03%
30 / 1
0.03%
0 / 0
0%
-8 / -6
-0.08%

@palatter palatter enabled auto-merge (squash) October 10, 2024 16:02
@palatter palatter merged commit 75b4a55 into main Oct 10, 2024
51 of 70 checks passed
@palatter palatter deleted the palatter/rte-toggle-issue branch October 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants