Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis.yml: add integration tests #40

Merged
merged 4 commits into from
Jul 27, 2016
Merged

travis.yml: add integration tests #40

merged 4 commits into from
Jul 27, 2016

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Jul 26, 2016

⚠️⚠️ this is expected to fail until #24 and #32 are merged. once they are in, I will rebase and we should start getting CI running our integration test suite as well.


  • change sudo:true so that we can get a Docker engine
    • this will slow down the time to get a test box (a few mins)
      but it should be fine
  • add bats in 'install'
  • print docker info prior to testing
  • execute bats

@boumenot
Copy link
Member

LGTM.

- change sudo:true so that we can get a Docker engine
    - this will slow down the time to get a test box (a few mins)
      but it should be fine
- add bats in 'install'
- print docker info prior to testing
- execute bats
@ahmetb
Copy link
Contributor Author

ahmetb commented Jul 27, 2016

rebased

ahmetb added 3 commits July 27, 2016 14:40
apparently travis uses /bin/sh to run tests; not /bin/bash
so [[ is missing. In this case we can safely change to [.
@ahmetb
Copy link
Contributor Author

ahmetb commented Jul 27, 2016

@boumenot w00t it worked. Added some commits to make travis work. PTAL later: 4eacb59...792d491

I discovered a flakiness in one test where wait-for-enable exited immediately because the nohup did not yet start the child process fully. will patch wait-for-enable by adding an initial 1s delay.

@ahmetb ahmetb merged commit d560e6d into Azure:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants