minor fixes in 'Pushing output files' example

[zerweck]

The sharedKeys object is not necessary to select the storageAccount object. Also, the storageAccountName is already an object in this script, but was referred as a string.

[brnleehng]

Hi @zerweck

Are you using an older version of the credentials configuration file?

Thanks,
Brian

[zerweck]

Hi @brnleehng
No, I just ran the 'Getting Started script' 2 days ago from the Azure Shell. The JSON that the Batch Explorer gives me also has the structure for Shared Key authentication like this:

{
  "batchAccount": {
    "name": "asd",
    "key": "xxx",
    "url": "https://asd.batch.azure.com"
  },
  "storageAccount": {
    "name": "asd",
    "key": "xxx",
    "endpointSuffix": "core.windows.net"
  },
  "githubAuthenticationToken": {}
}

Since this file is parsed via fromJSON in the given example, no list object sharedKeys is needed to subselect the storage account parameters.

[zerweck]

If have now identified the following two sources for the version of the credentials.json without the sharedKeys object:

1. doAzureParallel/account_setup.py

   Lines 533 to 546 in 9e9b494

   	secrets = format_secrets(
   	**{
   	"batchAccount": {
   	"name": kwargs["batch_account"],
   	"key": kwargs["batch_account_key"],
   	"url": kwargs["batch_account_url"]
   	},
   	"storageAccount": {
   	"name": kwargs["storage_account"],
   	"key": kwargs["storage_account_key"],
   	"endpointSuffix": kwargs["storage_account_endpoint_suffix"]
   	}
   	}
   	)

2. Selecting doAzureParallel in the Batch Explorer "Credentials and code samples for this Batch account" window (current Version 2.2.0-stable.368)

The only place where it is created with the sharedKeys object is doAzureParallel::generateCredentialsConfig. I am now wondering if the version without sharedKeys is outdated or the generateCredentialsConfig is non-standard.

[brnleehng]

This appears the set up script is outdated. The config file should include sharedKeys property to support our AAD credentials.

I'll take a look on adding the fix.

Thanks,
Brian