-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reusable workflow for linux integrations #445
reusable workflow for linux integrations #445
Conversation
16f65ce
to
57fdc8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️🙏 Thank you for the kind ping! The PR is looking great; I’ve added a few thoughts. It might also be worth checking if we can upgrade checkout to v4. Additionally, I noticed that download-artifact is tied to a specific hash, while for others, we only use the version—just an observation to share.
Everything else looks good, and I trust this has been tested against a fork or similar setup.
Thanks so much!
once the source of truth for integration tests is moved into a reusable workflow, dependabot will be able to open PRs on theese as well which will resolve many of the version bumps. previously dependabot couldn't upgrade the actions as they were re-generated from the bash file each time |
Co-authored-by: Tatsinnit <[email protected]>
Description
Remove the existing shell script generated integration testing configuration in favor of using reusable github actions and a matrix
Fixes # (issue)
Feature # (details)
Type of change
How Has This Been Tested?
Checklist: