Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reusable workflow for linux integrations #445

Merged
merged 39 commits into from
Dec 30, 2024

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Dec 12, 2024

Description

Remove the existing shell script generated integration testing configuration in favor of using reusable github actions and a matrix

Fixes # (issue)
Feature # (details)

Type of change

  • Refactor

How Has This Been Tested?

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero force-pushed the davidgamero/integrations-reusable-workflows branch from 16f65ce to 57fdc8e Compare December 17, 2024 22:40
@davidgamero davidgamero changed the title reusable workflow for helm integrations reusable workflow for linux integrations Dec 18, 2024
@davidgamero davidgamero marked this pull request as ready for review December 18, 2024 00:32
@Tatsinnit Tatsinnit requested a review from Copilot December 18, 2024 00:40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️🙏 Thank you for the kind ping! The PR is looking great; I’ve added a few thoughts. It might also be worth checking if we can upgrade checkout to v4. Additionally, I noticed that download-artifact is tied to a specific hash, while for others, we only use the version—just an observation to share.

Everything else looks good, and I trust this has been tested against a fork or similar setup.

Thanks so much!

@davidgamero
Copy link
Collaborator Author

once the source of truth for integration tests is moved into a reusable workflow, dependabot will be able to open PRs on theese as well which will resolve many of the version bumps.

previously dependabot couldn't upgrade the actions as they were re-generated from the bash file each time

@Tatsinnit Tatsinnit added the enhancement New feature or request label Dec 18, 2024
@davidgamero davidgamero merged commit 917b221 into main Dec 30, 2024
147 checks passed
@davidgamero davidgamero deleted the davidgamero/integrations-reusable-workflows branch December 30, 2024 19:32
audrastump pushed a commit to audrastump/draft that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants