fix race

pkg/controllers/workgenerator/controller.go

@@ -272,23 +272,25 @@ func (r *Reconciler) syncAllWork(ctx context.Context, resourceBinding *fleetv1be
 				if err != nil {
 					return false, err
 				}
+				activeWork[work.Name] = work
 				newWork = append(newWork, work)
 			} else {
 				simpleManifests = append(simpleManifests, fleetv1beta1.Manifest(selectedResource))
 			}
 		}
 		if len(simpleManifests) != 0 {
 			// generate a work object for the manifests if there are still any non enveloped resources
-			newWork = append(newWork, generateSnapshotWorkObj(workNamePrefix, resourceBinding, snapshot, simpleManifests))
+			work := generateSnapshotWorkObj(workNamePrefix, resourceBinding, snapshot, simpleManifests)
+			activeWork[work.Name] = work
+			newWork = append(newWork, work)
 		} else {
 			klog.V(2).InfoS("the snapshot contains enveloped resource only", "snapshot", klog.KObj(snapshot))
 		}
 		// issue all the create/update requests for the corresponding works for each snapshot in parallel
 		for i := range newWork {
 			work := newWork[i]
-			activeWork[work.Name] = work
 			errs.Go(func() error {
-				updated, err := r.upsertWork(cctx, work, existingWorks[work.Name], snapshot)
+				updated, err := r.upsertWork(cctx, work, existingWorks[work.Name].DeepCopy(), snapshot)
 				if err != nil {
 					return err
 				}