-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interface: add more stagedUpdateRun additionalPrintColumns #1008
base: main
Are you sure you want to change the base?
Conversation
80b0d09
to
e0058dc
Compare
e0058dc
to
e4822b7
Compare
@@ -17,6 +17,13 @@ import ( | |||
// +kubebuilder:subresource:status | |||
// +kubebuilder:resource:scope=Cluster,categories={fleet,fleet-placement},shortName=crsur | |||
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
// +kubebuilder:printcolumn:JSONPath=`.spec.placementName`,name="Placement",type=string | |||
// +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="ResourceSnapshot",type=string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a question about this field.
we want an index or a name? from the example you provided, it's a name.
The resources could be divided to multiple snapshots.
// +kubebuilder:printcolumn:JSONPath=`.spec.placementName`,name="Placement",type=string | ||
// +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="ResourceSnapshot",type=string | ||
// +kubebuilder:printcolumn:JSONPath=`.spec.stagedRolloutStrategyName`,name="Strategy",priority=1,type=string | ||
// +kubebuilder:printcolumn:JSONPath=`.status.policySnapshotIndexUsed`,name="PolicySnapshot",type=string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto, name or index?
i remember policySnapshot won't be divided to multiple ones.
@@ -397,6 +404,10 @@ type ClusterStagedUpdateRunList struct { | |||
// +kubebuilder:subresource:status | |||
// +kubebuilder:resource:scope=Cluster,categories={fleet,fleet-placement},shortName=careq | |||
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
// +kubebuilder:printcolumn:JSONPath=`.spec.parentStageRollout`,name="UpdateRun",type=string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the "-" to split the words?
Description of your changes
Add additionalPrinterColumns for
clusterStagedUpdateRun
andclusterApprovalRequest
objects.Update the examples to use the v1beta1 APIs.
The
get
command outputs now look like:Fixes #
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer