feat: enable the CRP controller to process DiffReported condition #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactored the code as discussed offline. |
zhiying-lin
reviewed
Jan 20, 2025
pkg/controllers/clusterresourceplacement/placement_status_test.go
Outdated
Show resolved
Hide resolved
zhiying-lin
reviewed
Jan 20, 2025
|
Note: as prev. discussed, the minor change needed on the CRP watcher will be sent as a separate PR. |
zhiying-lin
reviewed
Jan 21, 2025
pkg/utils/condition/condition.go
Outdated
| TotalCondition | ||
| ) | ||
|
|
||
| var ( | ||
| // Different set of condition types that Fleet will populate. | ||
| CondTypesForCSAAndSSAApplyStrategies = []ResourceCondition{ |
There was a problem hiding this comment.
i was thinking ReportDiff is a CondTypesForNoApplyOperationStrategies.
yeah, using the full name may be better.
zhiying-lin
reviewed
Jan 23, 2025
michaelawyu
commented
Jan 23, 2025
| @@ -109,7 +109,7 @@ func TestFindPlacementsSelectedDeletedResV1Alpha1(t *testing.T) { | |||
| Status: fleetv1alpha1.ClusterResourcePlacementStatus{ | |||
| SelectedResources: []fleetv1alpha1.ResourceIdentifier{ | |||
| { | |||
| Group: "abd", | |||
| Group: "xyz", | |||
There was a problem hiding this comment.
This change is solely made to pass the codespeller check; apparently the program thinks abd as a misspelling.
There was a problem hiding this comment.
Same for the change below.
zhiying-lin
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR enables the CRP controller to process DiffReported condition.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer