Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use index number in clusterStagedUpdateRun and add ApprovalAccepted status to ApprovalRequests #1019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use index number in clusterStagedUpdateRun and add ApprovalAccepted status to ApprovalRequests #1019

wants to merge 2 commits into from
+492 −112

Conversation

jwtty
Copy link
Contributor

@jwtty jwtty commented Jan 17, 2025 •
edited
Loading

Description of your changes

  1. Show index in PolicySnapshotIndexObserved in updateRun status
  2. Accept index in ResourceSnapshotIndex in updateRun spec
  3. Add ApprovalAccepted status in approvalRequests
  4. Fix the waitTime flaky UT (use no earlier than instead of after)
  5. Fix observedClusterCount difference for pickAll policy in validation.

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@jwtty jwtty changed the title fix: use index instead of name in PolicySnapshotIndexUsed and resourceSnapshotIndex fix: use index in PolicySnapshotIndexUsed and resourceSnapshotIndex Jan 17, 2025
@jwtty jwtty force-pushed the stagerun-index-fix branch 3 times, most recently from 2843cee to 79a44b9 Compare January 21, 2025 23:01
@jwtty jwtty changed the title fix: use index in PolicySnapshotIndexUsed and resourceSnapshotIndex fix: use index number in clusterStagedUpdateRun and add ApprovalAccepted status to ApprovalRequests Jan 22, 2025
@jwtty jwtty force-pushed the stagerun-index-fix branch 5 times, most recently from c9bf1a9 to dd0aad0 Compare January 23, 2025 20:02
@jwtty jwtty force-pushed the stagerun-index-fix branch from dd0aad0 to fe9aefe Compare January 23, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwtty