feat: add data resources availability #1027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -255,6 +255,32 @@ func isDataResource(gvr schema.GroupVersionResource) bool { | |||
| return true | |||
| case utils.ClusterRoleBindingGVR: | |||
| return true | |||
| case utils.ServiceAccountGVR: | |||
There was a problem hiding this comment.
how do we know the secret associated with the SA is mounted/generated
Comment on lines
+262
to
+265
| case utils.CSIDriverGVR: | ||
| return true | ||
| case utils.CSINodeGVR: | ||
| return true |
There was a problem hiding this comment.
do we propagate those?
| return true | ||
| case utils.CSIStorageCapacityGVR: | ||
| return true | ||
| case utils.ControllerRevisionGVR: |
There was a problem hiding this comment.
do we propagate this?
Comment on lines
+276
to
+279
| case utils.MutatingWebhookConfigurationGVR: | ||
| return true | ||
| case utils.ValidatingWebhookConfigurationGVR: | ||
| return true |
There was a problem hiding this comment.
these two don't look like data resource since the real webhook server needs to be setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have: add resources to
isDataResourcefor resources that don't have conditions that is related to it's availabilitymake reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer