Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more scheduler integration tests (4/) #544

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

michaelawyu
Copy link
Contributor

Description of your changes

This PR adds more scheduler integration tests.

Note that it also features two fixes sent earlier, which will be rebased after they are merged.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

N/A

Special notes for your reviewer

N/A

zhiying-lin
zhiying-lin previously approved these changes Oct 10, 2023
Copy link
Contributor

@zhiying-lin zhiying-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments, others lgtm

test/scheduler/actuals_test.go Outdated Show resolved Hide resolved
test/scheduler/actuals_test.go Outdated Show resolved Hide resolved
@michaelawyu
Copy link
Contributor Author

Merged to unblock progress; approval acquired previously -> no major changes afterwards.

If there's any concern, please let me know.

@michaelawyu michaelawyu merged commit 5b4da69 into Azure:main Oct 16, 2023
11 checks passed
@michaelawyu michaelawyu deleted the scheduler-integration-tests-4 branch October 16, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants