fix: track generate name in the WorkResourceIdentifier #954
Conversation
|
|
||
| // GenerateName is the generate name of the resource. This field will be populated if the | ||
| // object to place has a generate name only. | ||
| GenerateName string `json:"generateName,omitempty"` |
There was a problem hiding this comment.
can we not fill the Name field with the GenerateName in this case?
There was a problem hiding this comment.
Hi Ryan! The two fields are separate as once applied we should use/reveal the real name of the object; this helps the work applier/user to identify corresponding objects quicker. I think it might be less confusing to the customer as well.
There was a problem hiding this comment.
"name: = "generateName" when the generateName is used, right? Work API is not a customer facing object so I don't think the customer need to care. I worry about the backward compatibility of the new field though.
|
Discussed offline -> for now Fleet will drop the support for generate names (currently the support is broken anyway). |
Description of your changes
This API change is a prerequisite for Fleet to fix the issue where objects with generate names cannot be applied correctly.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
N/A
Special notes for your reviewer
API change only; currently the field is not yet populated.