Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic binding introduced with #1841 #2071

Open
kbeaugrand opened this issue Apr 2, 2023 · 0 comments
Open

Remove dynamic binding introduced with #1841 #2071

kbeaugrand opened this issue Apr 2, 2023 · 0 comments

Comments

@kbeaugrand
Copy link
Collaborator

Description
Some dynamic binding has been introduced in LoRaEngine/modules/LoRaWanNetworkSrvModule/LoraTools/IoTHubImpl/IoTHubTwinPropertiesContainer.cs.
This dynamic binding comes because this class is a partial abstraction of twin properties collection.

We must implement dedicated wrapper for twin properties that match with specifics instances of device twins to remove this dynamic binding.
However, this was not done in the #1841 because this impact a huge.

We might work to remove that in future refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant