Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - Wrapping TwinCollection to ITwinProperties interface #1841

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Refactor - Wrapping TwinCollection to ITwinProperties interface #1841

merged 3 commits into from
Apr 3, 2023

Conversation

kbeaugrand
Copy link
Collaborator

PR for wrapping TwinCollection to ITwinProperties interface

What is being addressed

The objective is to decouple the IDevice interface from the Microsoft.Azure.Devices namespace. This introduce the ITwinProperties that gives access to properties from the twin as usual.

This should be merged after #1822.

How is this addressed

  • Introduce the ITwinProperties interface
  • Add TwinProperties extensions methods
  • Adapt unit tests

@kbeaugrand kbeaugrand force-pushed the refactor/introduce_twin_properties_object branch 3 times, most recently from d4b14dd to 17e18f4 Compare August 30, 2022 17:07
@kbeaugrand kbeaugrand force-pushed the refactor/introduce_twin_properties_object branch from 17e18f4 to e86f219 Compare November 2, 2022 15:12
@kbeaugrand kbeaugrand temporarily deployed to CI November 2, 2022 15:12 Inactive
@kbeaugrand kbeaugrand force-pushed the refactor/introduce_twin_properties_object branch from e86f219 to 3b9a5c0 Compare December 8, 2022 19:19
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:19 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand added the fullci Run full continuous integration label Dec 8, 2022
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:24 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:24 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:24 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:24 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:24 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand requested a review from Mandur December 8, 2022 19:25
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:26 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:26 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:26 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:26 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 19:29 — with GitHub Actions Inactive
@github-actions github-actions bot added SensorDecodingTest Indicate SensorDecodingTest passed OTAAJoinTest Indicate OTAAJoinTest passed labels Dec 8, 2022
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 20:36 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 20:36 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand added the 1️⃣ Priority 1 (One) label Dec 8, 2022
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 21:02 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 21:02 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 21:02 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI December 8, 2022 21:02 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 06:51 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 06:51 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 06:51 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 06:52 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand temporarily deployed to CI April 3, 2023 08:16 — with GitHub Actions Inactive
@github-actions github-actions bot added OTAATest Indicate OTAATest passed MacTest Indicate MacTest passed ClassCTest Indicate ClassCTest passed C2DMessageTest Indicate C2DMessageTest passed labels Apr 3, 2023
@Mandur Mandur added the 3️⃣ three label Apr 3, 2023
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:30 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:30 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:30 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:30 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:30 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:33 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:33 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:33 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 10:33 — with GitHub Actions Inactive
@github-actions github-actions bot added OTAAJoinTest Indicate OTAAJoinTest passed ABPTest Indicate ABPTest passed labels Apr 3, 2023
@Mandur Mandur temporarily deployed to CI April 3, 2023 11:42 — with GitHub Actions Inactive
@Mandur Mandur temporarily deployed to CI April 3, 2023 11:42 — with GitHub Actions Inactive
@Mandur Mandur merged commit e74a06a into dev Apr 3, 2023
@Mandur Mandur deleted the refactor/introduce_twin_properties_object branch April 3, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mandur Mandur Mandur approved these changes

Assignees
No one assigned
Labels
1️⃣ Priority 1 (One) 2️⃣ Priority 2 (Two) 3️⃣ three ABPTest Indicate ABPTest passed C2DMessageTest Indicate C2DMessageTest passed ClassCTest Indicate ClassCTest passed CloudDeploymentTest fullci Run full continuous integration MacTest Indicate MacTest passed OTAAJoinTest Indicate OTAAJoinTest passed OTAATest Indicate OTAATest passed SensorDecodingTest Indicate SensorDecodingTest passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbeaugrand @codecov-commenter @Mandur