Running LoRaWAN Network Server decoupled from IoT Edge #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding EdgeDeviceGetter and tests * Formatting and changing accessibility * Locking on redis cache * Adding to DI * Introducing cancellation token * Logging an error if we were not able to update redis * Adding prefix * Missed one statement * Adding timeout logic
…dis NuGet Package (#1693) * Adding StackExchange.Redis NuGet package * Adding RedisConnectionString environment variable to configuration * Adding a configuration unit test * Redis subscriber implementation (#1699) * Fixing injection * Making analyzer happy about null reference exceptions * Fixing UTs * Additional UT fix * Update LoRaEngine/modules/LoRaWanNetworkSrvModule/LoRaWan.NetworkServer/NetworkServerConfiguration.cs Co-authored-by: Bastian Burger <[email protected]> Co-authored-by: Bastian Burger <[email protected]>
Co-authored-by: danigian <[email protected]>
* Providing alternatives to IOTEDGE_* environment variables * Falling back without if else
Co-authored-by: Patrick Schuler <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bastian Burger <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| TheoryDataFactory.From( | ||
| (string.Empty, "Unable to parse Json when attempting to close"), | ||
| ("null", "Missing payload when attempting to close the"), | ||
| (JsonSerializer.Serialize(new { DevEui = (string)null, Fport = 1 }), "DevEUI missing"), |
Check warning
Code scanning / CodeQL
Useless upcast
| { | ||
| _ = loggingBuilder.ClearProviders(); | ||
| var logLevel = int.TryParse(NetworkServerConfiguration.LogLevel, NumberStyles.Integer, CultureInfo.InvariantCulture, out var logLevelNum) | ||
| ? (LogLevel)logLevelNum is var level && Enum.IsDefined(typeof(LogLevel), level) ? level : throw new InvalidCastException() |
Check warning
Code scanning / CodeQL
Constant condition
| { | ||
| _ = loggingBuilder.ClearProviders(); | ||
| var logLevel = int.TryParse(NetworkServerConfiguration.LogLevel, NumberStyles.Integer, CultureInfo.InvariantCulture, out var logLevelNum) | ||
| ? (LogLevel)logLevelNum is var level && Enum.IsDefined(typeof(LogLevel), level) ? level : throw new InvalidCastException() |
Check warning
Code scanning / CodeQL
Constant condition
| { | ||
| _ = loggingBuilder.ClearProviders(); | ||
| var logLevel = int.TryParse(NetworkServerConfiguration.LogLevel, NumberStyles.Integer, CultureInfo.InvariantCulture, out var logLevelNum) | ||
| ? (LogLevel)logLevelNum is var level && Enum.IsDefined(typeof(LogLevel), level) ? level : throw new InvalidCastException() |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
LoRaEngine/LoraKeysManagerFacade/FunctionsBundler/DeduplicationExecutionItem.cs
Fixed
Show fixed
Hide fixed
Comment on lines
+70
to
+77
| if (isCloudDeployment && !shouldSetRedisString) | ||
| { | ||
| _ = Assert.Throws<InvalidOperationException>(lnsConfigurationCreation); | ||
| } | ||
| else | ||
| { | ||
| _ = lnsConfigurationCreation(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
4 tasks
Comment on lines
+118
to
+121
| catch (Exception) | ||
| { | ||
| // Dispose all basics stations | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Codecov Report
@@ Coverage Diff @@
## dev #1746 +/- ##
==========================================
+ Coverage 86.58% 86.75% +0.16%
==========================================
Files 236 243 +7
Lines 9279 9480 +201
==========================================
+ Hits 8034 8224 +190
- Misses 1245 1256 +11
Continue to review full report at Codecov.
|
github-actions
bot
added
CloudDeploymentTest
SensorDecodingTest
Mandur
reviewed
Jul 4, 2022
Mandur
reviewed
Jul 4, 2022
...WanNetworkSrvModule/LoRaWan.NetworkServer/BasicsStation/BasicsStationNetworkServerStartup.cs
Show resolved
Hide resolved
Mandur
approved these changes
Jul 4, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1553
What is being addressed
This PR is bringing into dev branch all the work related to Decouple LNS from Edge milestone
Validation: