Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the local development again #1849

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

Mandur
Copy link
Contributor

@Mandur Mandur commented Sep 1, 2022

The local development experience was only partially fixed by #1808. There is still one condition missing that wants the local development to connect to the redis. This PR aims to finally fix the issue

@codecov-commenter
Copy link

Codecov Report

Merging #1849 (75714f5) into dev (99ab8ba) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1849      +/-   ##
==========================================
- Coverage   87.43%   87.41%   -0.02%     
==========================================
  Files         251      251              
  Lines        9573     9575       +2     
==========================================
  Hits         8370     8370              
- Misses       1203     1205       +2     
Impacted Files Coverage Δ
...BasicsStation/BasicsStationNetworkServerStartup.cs 59.68% <100.00%> (ø)
...oRaWan.NetworkServer/NetworkServerConfiguration.cs 100.00% <100.00%> (ø)
...oRaWan.NetworkServer/ManagedConnectionException.cs 0.00% <0.00%> (-25.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mandur Mandur marked this pull request as ready for review September 1, 2022 14:42
Copy link
Collaborator

@danigian danigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a quick fix is fine. Maybe we should add an item in the backlog for setting up a redis instance for local development, rather than running in "iot edge" mode

@Mandur
Copy link
Contributor Author

Mandur commented Sep 8, 2022

Created #1855

@Mandur Mandur merged commit 9cdeb36 into dev Sep 8, 2022
@Mandur Mandur deleted the feature/fix-local-dev-reloaded branch September 8, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants