Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaledjob support. #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add scaledjob support. #289

wants to merge 1 commit into from

Conversation

x-projs
Copy link

@x-projs x-projs commented Jun 14, 2023

No description provided.

@x-projs x-projs requested a review from a team as a code owner June 14, 2023 16:30
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jun 28, 2023
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -32,6 +32,7 @@ export const WORKLOAD_TYPES: string[] = [
'replicaset',
'daemonset',
'pod',
'scaledjob',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a UT for this change in kubernetesTypes.test.ts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants