test(e2e): update to add approval comment workflow for e2e trigger #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliedmcb
commented
Nov 7, 2023
charliedmcb
changed the title
tallaxes
approved these changes
Nov 8, 2023
3 tasks
charliedmcb
deleted the
charliedmcb/updateToUseApprovalCommentWorkflowForE2ETrigger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Currently for PR check-in the E2E suite is run via an approval comment directly for the e2e trigger workflow.
This works to test things, but overall has some quality of life issues, as if another approval comes in the trigger will be checked again, un-linking the previous e2e run from the PR regardless of if a new E2E suite run was requested or not.
This PR is step one of two meant to break apart the approval comment check so that the E2E suite run will not be overridden by a new review. This one added the new trigger scenario. Another follow up will be made once tested to remove the old trigger.
How was this change tested?
Not able to test since this trigger only works when in the default branch. Due to this I'm only adding the new trigger, and not removing the old one. Once we've tested that it works correctly in the
mainbranch than I'll remove the old trigger scenario.*
Does this change impact docs?
Release Note