Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provisioning): add cilium taint and label #516

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Oct 9, 2024

Description

Adds cilium startup taint (https://karpenter.sh/docs/concepts/nodepools/#cilium-startup-taint) and add cillium ebpf-dataplaine label (so that Karpenter can take the corresponding DaemonSet into account when computing the expected overhead), to example and default E2E NodePools.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added area/networking Issues or PRs related to networking area/e2e-test-framework Issues or PRs related to refactoring the e2e test framework area/provisioning Issues or PRs related to provisioning (instance provider) labels Oct 9, 2024
@tallaxes tallaxes self-assigned this Oct 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11261736980

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.905%

Totals Coverage Status
Change from base Build 11165629944: 0.0%
Covered Lines: 36307
Relevant Lines: 37084

💛 - Coveralls

@tallaxes tallaxes merged commit 960d6fc into main Oct 11, 2024
22 checks passed
@tallaxes tallaxes deleted the tallaxes/fix-provisioning branch October 11, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-test-framework Issues or PRs related to refactoring the e2e test framework area/networking Issues or PRs related to networking area/provisioning Issues or PRs related to provisioning (instance provider)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants