Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc: configuration settings for GA #1016

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Arc: configuration settings for GA #1016

wants to merge 14 commits into from

Conversation

gracewehner
Copy link
Contributor

@gracewehner gracewehner commented Nov 18, 2024

PR Description

  • Remove Arc proxy cluster deployment for now until it's added back so our pipelines succeed
  • Add in configuration-settings for Arc:
    • Use the Arc cluster cloud setting unless the customer has overridden it. Out-of-the-box, mooncake and fairfax should just work with this. But we still want an override parameter because there used to be an issue with Azure HCI clusters where this wasn't set correctly for public clouds. This was fixed, but we still want it to be backwards compatible and be able to address any similar issues in the future where the value from the Arc cluster itself is wrong.
    • Do the same as above for the Arc cluster distribution setting. We use this to evaluate if the cluster is AKS EE and forbids mounting the ubuntu CA cert directory.
    • Add general parameters to mount or not mount the Ubuntu/Mariner CA cert directories. This is for cases like GKE where the customer may have nodes that prevent mounting the ubuntu CA cert directory. We don't want to add this for all GKE distros though because some may have Ubuntu nodes
    • Customer can use the helm value/configuration setting "DeploymentReplicas" (which is set to default to 2) to increase the number of shards if needed, similarly to how we toggled AKS clusters
  • Use a helper template for Arc settings so that the boolean conditions are only evaluated once and only follow one path in the code to prevent issues from typos or future changes

New Feature Checklist

  • List telemetry added about the feature:
    • Added to telegraf:
      • isarcextension = "$IS_ARC_EXTENSION"
      • arcdistribution = "$ARC_DISTRIBUTION"
      • mountmarinercerts = "$MOUNT_MARINER_CERTS"
      • mountubuntucerts = "$MOUNT_UBUNTU_CERTS"

@gracewehner gracewehner requested a review from a team as a code owner November 18, 2024 23:08
@gracewehner
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

github-actions bot commented Dec 5, 2024

This PR was closed because it has been stalled for 12 days with no activity.

@github-actions github-actions bot closed this Dec 5, 2024
@vishiy vishiy reopened this Dec 8, 2024
Copy link

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@vishiy vishiy marked this pull request as draft December 15, 2024 15:57
@gracewehner gracewehner marked this pull request as ready for review December 16, 2024 20:50
@gracewehner
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants