Pylint updates, CI workflows, attrs updates

[devanshjainms]

Description

This pull request includes several updates to GitHub Actions workflows and some minor code refactoring. The most important changes are the addition of new workflows for security and dependency management, updates to existing workflows, and code improvements for better readability and maintainability.

GitHub Actions Workflows:

• CodeQL Analysis: Added a new workflow for CodeQL analysis to detect vulnerabilities in JavaScript and Python code. This workflow runs on pushes and pull requests to the main and development branches and on a weekly schedule.
• Dependency Review: Introduced a new workflow to scan dependency manifest files for known vulnerabilities during pull requests. This helps prevent merging PRs with vulnerable packages.
• OSSF Scorecard: Added a workflow to run the OpenSSF Scorecard for supply-chain security analysis, scheduled weekly and on pushes to the main branch.
• Trivy Vulnerability Scanner: Implemented a workflow to run Trivy for vulnerability scanning on pull requests, merge groups, and manual dispatch.

Code Refactoring:

• Exception Handling:
• Standardized exception variable naming across multiple files by renaming exception variables from e to ex for better readability.
• Python Version Update: Updated the Python version to 3.10 in the GitHub Actions workflows for Ansible linting and code coverage.
• Pylint Configuration: Enhanced the Pylint configuration in pyproject.toml by adding new rules and organizing the configuration sections for better maintainability.
  These changes improve the project's security, code quality, and maintainability.

Problem Statement

• Incorrect HANA RHEL attributes.
• Missing CI workflows for codeql, ossf

Solution Details

• Implementation changes
• Configuration updates
• Documentation updates

Test Cases

• Unit tests added/updated
• Manual Testing done

Checklist

• Code follows project style guidelines
• Documentation has been updated
• Tests are passing
• PR title follows conventional commit format
• Breaking changes are clearly marked

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull Request Overview

This PR updates CI/CD workflows, configuration settings, and docstrings to improve code quality and correctness while updating HANA RHEL attributes. Key changes include:

• New and updated GitHub workflow files for CodeQL analysis, dependency review, OSSF scorecard, Trivy scans, GitHub Actions for code coverage, and ansible lint.
• Enhanced pylint configuration in pyproject.toml with additional docstring settings and naming styles.
• Docstring and error-handling updates in various source modules to use a consistent exception variable naming convention.

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
.github/workflows/codeql.yml	Adds a workflow for CodeQL scanning
.github/workflows/dependency-review.yml	Introduces a workflow for dependency review
.github/workflows/ossf-scoreboard.yml	Adds a workflow for OSSF supply-chain security analysis
.github/workflows/trivy.yml	Introduces a workflow for Trivy vulnerability scanning
pyproject.toml	Updates pylint settings and docstring configuration
.github/workflows/github-actions-code-coverage.yml	Updates Python version and adds a pylint step
src/modules/get_pcmk_properties_db.py	Improves docstrings and exception handling consistency
.github/workflows/github-actions-ansible-lint.yml	Updates Python version for ansible lint
src/modules/get_pcmk_properties_scs.py	Enhances docstring details and exception handling
src/modules/filesystem_freeze.py	Updates exception variable naming for consistency
src/modules/log_parser.py	Uses consistent exception naming in log parsing
src/modules/get_azure_lb.py	Standardizes exception handling in network client creation and LB details
src/modules/render_html_report.py	Updates exception naming consistency in report rendering
src/modules/send_telemetry_data.py	Updates exception naming consistency
src/modules/check_indexserver.py	Improves error message consistency when checking indexserver configuration
src/module_utils/sap_automation_qa.py	Standardizes exception naming and removes an unneeded import
src/modules/get_package_list.py	Updates exception naming consistency
src/modules/location_constraints.py	Standardizes exception handling
src/module_utils/get_cluster_status.py	Uses consistent exception variable naming
src/modules/get_cluster_status_scs.py	Removes an unused import and updates docstring details

Comments suppressed due to low confidence (2)

.github/workflows/github-actions-code-coverage.yml:35

• [nitpick] The use of shell substitution (i.e. $(git ls-files '*.py')) in the pylint command could lead to issues on some environments or with filenames containing spaces. Consider verifying that the command behaves as expected or restructuring it for more robust file handling.

pylint --load-plugins=pylint.extensions.docparams --fail-under=9 --disable=R $(git ls-files '*.py') --rcfile=./pyproject.toml

.github/workflows/ossf-scoreboard.yml:31

• [nitpick] The commented-out line contains a concatenated URL and text, which appears to be a typo. Consider removing or correcting it for clarity.

#      # actions: readhttps://github.com/hdamecharla/sap-automation-kimforss/tree/main