impl compare for FabricErrorCode (#110)

FabricErrorCode needs PartialEq impl for comparison.
Azure · Dec 12, 2024 · 8892f31 · 8892f31
1 parent 5781c7d
commit 8892f31
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/crates/libs/core/src/error/errorcode.rs b/crates/libs/core/src/error/errorcode.rs
@@ -47,7 +47,7 @@ const E_NOT_FOUND: FABRIC_ERROR_CODE =
 macro_rules! define_fabric_error_code{
     ($( $code1:ident ),* ,($lit:literal), $( $code:ident ),*) =>{
         #[allow(non_camel_case_types)]
-        #[derive(Debug, Clone)]
+        #[derive(Debug, Clone, PartialEq)]
         #[repr(i32)]
         pub enum FabricErrorCode {
             // Define windows error codes for SF

diff --git a/crates/libs/core/src/error/mod.rs b/crates/libs/core/src/error/mod.rs
@@ -19,6 +19,11 @@ impl FabricError {
     pub fn new(code: HRESULT) -> Self {
         Self(code)
     }
+
+    /// Convert to fabric error code if possible.
+    pub fn try_as_fabric_error_code(&self) -> Result<FabricErrorCode, &str> {
+        FabricErrorCode::try_from(FABRIC_ERROR_CODE(self.0 .0))
+    }
 }
 
 impl From<HRESULT> for FabricError {
@@ -104,6 +109,10 @@ mod test {
         );
         let e = crate::Error::from(fe.clone());
         assert_eq!(e.code(), fe.into());
+        let ec = FabricError::from(e)
+            .try_as_fabric_error_code()
+            .expect("unknown code");
+        assert_eq!(ec, FabricErrorCode::FABRIC_E_CODE_PACKAGE_NOT_FOUND);
     }
 
     #[test]