-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pipeline to run aks free vs. standard test #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssa1303
previously approved these changes
Oct 17, 2024
sumanthreddy29
previously approved these changes
Oct 17, 2024
anson627
dismissed stale reviews from sumanthreddy29 and alyssa1303
via
October 17, 2024 23:14
187a0fb
pipelines/perf-eval/apiserver-benchmark-virtualnodes10-pods100.yml
Outdated
Show resolved
Hide resolved
pipelines/perf-eval/apiserver-benchmark-virtualnodes10-pods100.yml
Outdated
Show resolved
Hide resolved
anson627
force-pushed
the
add-free-vs-standard-pipeline
branch
from
October 18, 2024 23:15
d7feded
to
08c47dd
Compare
alyssa1303
reviewed
Oct 22, 2024
alyssa1303
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the Azure performance evaluation pipeline and the steps for collecting cloud information and setting Terraform input variables. The most important changes include modifying the stages to add new tiers, updating the
collect-cloud-info.yml
to include SKU tier information, and setting SKU tier in Terraform input variables.Updates to Azure performance evaluation pipeline:
pipelines/perf-eval/apiserver-benchmark-virtualnodes10-pods100.yml
: Renamed theazure_eastus2
stage toazure_eastus2_free
and added a newazure_eastus2_standard
stage with appropriate parameters. [1] [2]Collecting cloud information:
steps/cloud/azure/collect-cloud-info.yml
: Added thesku_tier
argument to the cloud info collection script to capture the SKU tier of the AKS cluster.Setting Terraform input variables:
steps/terraform/set-input-variables-azure.yml
: IncludedSKU_TIER
in the environment variables to be set, which should be defined by the matrix.