Update AKS module with default configuration #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanthreddy29
changed the title
anson627
previously approved these changes
Oct 18, 2024
anson627
previously approved these changes
Oct 18, 2024
anson627
reviewed
Oct 18, 2024
sumanthreddy29
commented
Oct 18, 2024
pipelines/perf-eval/apiserver-benchmark-virtualnodes10-pods100.yml
Outdated
Show resolved
Hide resolved
sumanthreddy29
force-pushed
the
override-aks-network-policy
branch
from
7cb84a2 to
89f835f
Compare
sumanthreddy29
force-pushed
the
override-aks-network-policy
branch
from
89f835f to
6d760cc
Compare
alyssa1303
approved these changes
Oct 18, 2024
sumanthreddy29
added a commit
that referenced
this pull request
Oct 21, 2024
This reverts commit 6f5a77e.
sumanthreddy29
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the Terraform configuration for Azure, primarily focusing on enhancing the Kubernetes cluster setup and adding new variables for better configurability. The most important changes include updates to the
README.mdfor new environment variables, modifications to the main Terraform files to support auto-scaling and network policies, and updates to the input schema and variable definitions.Documentation Updates:
modules/terraform/azure/README.md: Added new environment variablesNETWORK_POLICYandEBPF_DATA_PLANEfor performance evaluation scenarios. ([[1]](https://github.com/Azure/telescope/pull/343/files#diff-6408a79a9cdb905ab9327763a955f3f5cd4d0af74ddb77f688f08a7f82e27ed0L19-R25),[[2]](https://github.com/Azure/telescope/pull/343/files#diff-6408a79a9cdb905ab9327763a955f3f5cd4d0af74ddb77f688f08a7f82e27ed0R64-R73))Terraform Configuration Enhancements:
modules/terraform/azure/aks/main.tf: Enabled auto-scaling and added an auto-scaler profile and automatic channel upgrade settings for the Kubernetes cluster. ([[1]](https://github.com/Azure/telescope/pull/343/files#diff-4089bc0576048d82e335da51ad0374e2e9c0ae37db3d65c3c784e97871651fd7R31),[[2]](https://github.com/Azure/telescope/pull/343/files#diff-4089bc0576048d82e335da51ad0374e2e9c0ae37db3d65c3c784e97871651fd7R42-R47))modules/terraform/azure/aks/main.tf: Removed deprecated settingsoidc_issuer_enabledandworkload_identity_enabled. ([modules/terraform/azure/aks/main.tfL52-L53](https://github.com/Azure/telescope/pull/343/files#diff-4089bc0576048d82e335da51ad0374e2e9c0ae37db3d65c3c784e97871651fd7L52-L53))Variable and Schema Updates:
modules/terraform/azure/aks/variables.tf: Updated default values fornetwork_pluginandnetwork_plugin_modeand added new optional variablesaks_network_policyandaks_ebpf_data_plane. ([modules/terraform/azure/aks/variables.tfL44-R45](https://github.com/Azure/telescope/pull/343/files#diff-e0b25de6470cd5774403141e8997adee371642381fd8430d6dd467f86d13b59eL44-R45))modules/terraform/azure/azure_input_schema.json: Added new fieldsaks_network_policyandaks_ebpf_data_planeto the input schema. ([modules/terraform/azure/azure_input_schema.jsonR13-R18](https://github.com/Azure/telescope/pull/343/files#diff-4f17a00034a463e9bcadcda2dcc8f0e03cd95603ec9329474618c9f7aad5deaeR13-R18))modules/terraform/azure/main.tf: Updated local variables to include new network policy settings and modified the logic for merging configurations. ([[1]](https://github.com/Azure/telescope/pull/343/files#diff-0f7f598ee8901914ae02cf0a5c9c9c1237e1bbe208688856f72a3af4e1cc12bbR5-R6),[[2]](https://github.com/Azure/telescope/pull/343/files#diff-0f7f598ee8901914ae02cf0a5c9c9c1237e1bbe208688856f72a3af4e1cc12bbL17-R46))modules/terraform/azure/variables.tf: Added new optional variablesaks_network_policyandaks_ebpf_data_planeto the JSON input variable definition. ([modules/terraform/azure/variables.tfR7-R8](https://github.com/Azure/telescope/pull/343/files#diff-a70d527b3b015f3aa3103f024416bbf9c1e2828c82890a61a97316c23e5402efR7-R8))