fixes requested during avm team review

[kewalaka]

to close #3

Review Feedback

• terraform.lock.hcl shouldn't be in the repo per the .gitignore file.

@mbilalamjad terraform.lock.hcl was introduced to the AVM template in this PR, has this review finding been superseded?

• Update the support.md file.

for @pradorodriguez please

• Consider following specs TFNFR31 for the local.tf file.

What was done was following the style of the KeyVault, which in my opinion is much more readable. However, I have merged the locals block into a single block (which I think is what your ask is).

• Consider updating version to 0.1.0 as the first version that would be published into the terraform registry per spec SNFR17.

done

• Consider updating output to contain Resource Name, ID and Object per specs RMFR7 & TFFR2.

done, though I don't much care for the 'system assigned mi' output. What if a user assigned identity is being used?

i also note that Keyvault doesn't include the outputs in RMFR7, they seem unnecessary since you can get to them via the full resource output, but, done :)

• Consider setting prevent_deletion_if_contains_resources to false in provider block in example code per spec TFNFR36.

done

• Consider setting a constraint on maximum major version of Provider per spec TFNFR26.

can't find any instances of this

• The Contributor and Owner teams are not added to the repo per spec SNFR20.

another one for @pradorodriguez , please.

[kewalaka]

also I noted:

@pradorodriguez would you update the github "about" please - i don't think I have access, it currently says:

About
AVM Terraform module for public IP address

[kewalaka]

Tests pass, except an external linting issue that has been recently introduced in the template upstream, there's a PR to fix that. All E2Es pass, evidence:

https://github.com/kewalaka/terraform-azurerm-avm-res-containerregistry-registry/actions/runs/7253195647

[kewalaka]

@pradorodriguez i've converted the PR to draft, if you can do the other support-related matters above please, then remove the draft status.

[pradorodriguez]

AVM Module Review #3