feat(subscription): add defender for cloud security contact configuration #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipebbc
force-pushed
the
feat/defendercontact
branch
3 times, most recently
from
9a38335
to
f0933a4
Compare
|
This looks great thanks for your efforts! |
felipebbc
force-pushed
the
feat/defendercontact
branch
2 times, most recently
from
f394a61
to
f3ad0cb
Compare
|
I see more commits tricking in. Are you happy with this work now @felipebbc ? |
Yes. Had to ignore the “location” field since it cannot be set by deployment, but it is set by Azure causing a change on subsequent runs. I’m good with this. |
felipebbc
force-pushed
the
feat/defendercontact
branch
from
4c4e7a4
to
b153276
Compare
|
Hi @matt-FFFFFF Anything pending from me to get this PR approved? |
|
Hi yes the check failures need addressing (make docs && make fmt) |
Updated. Thank you. |
matt-FFFFFF
previously approved these changes
Jun 7, 2024
auto-merge was automatically disabled
June 8, 2024 03:41
Head branch was pushed to by a user without write access
felipebbc
force-pushed
the
feat/defendercontact
branch
3 times, most recently
from
0b1c1c1
to
a3a2fed
Compare
Signed-off-by: felipebbc <[email protected]>
…tting Signed-off-by: felipebbc <[email protected]>
…e provided Signed-off-by: felipebbc <[email protected]>
Signed-off-by: felipebbc <[email protected]>
Signed-off-by: felipebbc <[email protected]>
Signed-off-by: felipebbc <[email protected]>
felipebbc
force-pushed
the
feat/defendercontact
branch
from
a3a2fed
to
b652b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/summary
Enable Microsoft Defender for Cloud contact settings within the subscription
Options:
This PR fixes/adds/changes/removes
Testing evidence
As part of this pull request I have
make fmt&make docsto format your code and update documentation.