azure-http-specs, add clientNamespace #1929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented.
|
|
You can try these changes here
|
weidongxu-microsoft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
tadelesh
reviewed
Nov 29, 2024
| name: "ClientNamespaceFirstClient", | ||
| service: Client.ClientNamespace, | ||
| }) | ||
| @clientNamespace("client.clientnamespace", "java") |
There was a problem hiding this comment.
is it possible to remove the scope? i believe every language needs to test ns customization.
There was a problem hiding this comment.
Every language would need to use slight different SDK namespace. E.g. csharp would use maybe Client.ClientNamespace.
And for Azure, .NET maybe Azure.###, and Java be com.azure.###. They are very different.
So I think whenever we had @clientNamespace, it would be one line for one language. I expect other language fill this line, when they are implementing the clientNamespace feature.
There was a problem hiding this comment.
@msyyc could you help to add python part?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Azure/cadl-ranch#758
move from Azure/cadl-ranch#775
This scenario mainly test the case when
@clientNamespaceapplied to TypeSpec Namespace/Interface/Model/Enum.So far it does not test corner cases, like client/subclient in different namespace, name conflict for model in different namespace, etc.
Current cases include