Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdk emitters to arm template #1977

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add sdk emitters to arm template #1977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions eng/feeds/arm/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,39 @@ options:
emitter-output-dir: "{project-root}/.."
azure-resource-provider-folder: "resource-manager"
output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/openapi.json"
"@azure-tools/typespec-csharp":
package-dir: {package-name}
clear-output-folder: true
model-namespace: false
namespace: "{package-dir}"
"@azure-tools/typespec-python":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msyyc could you verify?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is the meaning of normalizePackageName and ServiceNamespace and you can refer to the template https://github.com/Azure/azure-rest-api-specs/blob/ab67c148ec716a0d0075770742d54468f128c72e/specification/contosowidgetmanager/Contoso.Management/tspconfig.yaml#L18-L23

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from the data plane template:

typespec-azure/eng/feeds/data-plane/tspconfig.yaml

Line 15 in 9438df7

package-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}"

What do you recommend the generic value for package-dir should be?

package-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}"
package-name: "{package-dir}"
generate-test: true
generate-sample: true
"@azure-tools/typespec-java":
package-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}"
namespace: com.{{#toLowerCase}}{{parameters.ServiceNamespace}}{{/toLowerCase}}
service-name: "{service-name}"
"@azure-tools/typespec-ts":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanlwanl could you verify? is modular what we recommend for the template?

package-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}"
azureSdkForJs: true
isModularLibrary: true
generateMetadata: true
hierarchyClient: false
experimentalExtensibleEnums: true
enableOperationGroup: true
packageDetails:
name: "@azure/{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}"
"@azure-tools/typespec-go":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tadelesh could you verify?

service-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}"
package-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}"
module: "github.com/Azure/azure-sdk-for-go/{service-dir}/{package-dir}"
fix-const-stuttering: true
generate-examples: true
generate-fakes: true
head-as-boolean: true
inject-spans: true
linter:
extends:
- "@azure-tools/typespec-azure-rulesets/resource-manager"
Loading