add test cases for clientNamespace on anonymous models #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
No changes needing a change description found. |
|
You can try these changes here
|
…onymous-model-client-namespace
…approach to work it around but wait for upstream fixes
ArcturusZhang
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
iscai-msft
reviewed
Jan 21, 2025
| @@ -37,6 +72,67 @@ describe("typespec-client-generator-core: @clientNamespace", () => { | |||
| strictEqual(runner.context.sdkPackage.enums[0].clientNamespace, "TestService"); | |||
| }); | |||
|
|
|||
| it("namespace on anonymous response in a template", async () => { | |||
There was a problem hiding this comment.
I think you should be adding @clientNamespace tests as well, instead of just looking at .clientNamespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.