-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tcgc] Add @apiVersion scenarios and mock apis #2087
[tcgc] Add @apiVersion scenarios and mock apis #2087
Conversation
All changed packages have been documented.
|
You can try these changes here
|
packages/azure-http-specs/specs/azure/client-generator-core/api-version/main.tsp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the intension for this pr is to test the new @apiVersion
decorator. but i did not see it in the spec. am i miss anything?
…ralta/typespec-azure into api-version-scenarios
I only noticed that one of the examples didnt have the apiVersion decorator over it, but it's fixed now |
Also, I kind of think the origin folder is better, e.g. "azure/client-generator-core/api-version/header` etc. If I write the test, it would be azure/client-generator-core/api-version/header/main.tsp (
azure/client-generator-core/api-version/service.tsp
There is now not much in service.tsp, so it may be directly inserted into e.g. "header.tsp" |
Done. It would be great if we could have the docs mention this info + the conventions we'd like to follow. For example, not needing to specify |
packages/azure-http-specs/specs/azure/client-generator-core/api-version/header/main.tsp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pnpm generate-scenarios-summary
before merge.
@sarangan12 The CI seems still not fixed (about the verification of summary matches the lib)
…ralta/typespec-azure into api-version-scenarios
Add scenarios and mock apis for the tcgc
@apiVersion
decorator