Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Cluster Filtering in AKS VS Code Extension Tree Node #1208

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Jan 29, 2025

Description:

Enhance the AKS (Azure Kubernetes Service) VS Code extension by introducing a cluster filtering feature within the tree view. This will allow users to easily locate and manage specific clusters based on predefined filters, improving usability and efficiency.

Key Features:

Search & Filter: Users can apply filters based on cluster name.
Persistent Filtering: Selected filters remain active across sessions for a consistent user experience.
Dynamic Updates: The tree node updates in real-time as filters are applied or removed.
Multi-Filter Support: Users can combine multiple filter criteria to refine the cluster list further.
Clear & Reset Option: A quick way to reset filters and display all available clusters.

User Benefits:

  • Improved Navigation – Quickly find relevant clusters without scrolling through long lists.
  • Enhanced Productivity – Focus on specific clusters based on user-defined criteria.
  • Seamless Integration – Works natively within the VS Code extension tree node, ensuring a familiar experience. 🚀

Thank you for bringing this idea and humble fyi to @qpetraroia , @ReinierCC , @tejhan , @hsubramanianaks ❤️

VSIX to test:

vscode-aks-tools-1.5.5-clusterFilterTest1.vsix.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • package.json: Language not supported
  • src/extension.ts: Evaluated as low risk
  • src/tree/azureAccountTreeItem.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/commands/utils/clusterfilter.ts:54

  • [nitpick] Simplify the comparison by directly comparing 'filtered.clusterName' with 'cluster.name'.
picked: filteredClusters.some((filtered) => filtered.clusterName === parseResource(cluster.id!).name),
@Tatsinnit Tatsinnit self-assigned this Jan 29, 2025
@Tatsinnit Tatsinnit added the enhancement 🚀 New feature or request or improvements on existing code. label Jan 29, 2025
ReinierCC
ReinierCC previously approved these changes Jan 30, 2025
Copy link
Collaborator

@ReinierCC ReinierCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Cool Feature!

src/commands/utils/clusterfilter.ts Outdated Show resolved Hide resolved
src/commands/utils/clusterfilter.ts Outdated Show resolved Hide resolved
@Tatsinnit Tatsinnit merged commit bcfe001 into Azure:main Jan 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants