Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump glob and chai #108

Closed
wants to merge 18 commits into from
Closed

Bump glob and chai #108

wants to merge 18 commits into from

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Feb 16, 2024 •
edited
Loading

This PR updates following packages for dependent bot but it was all breaking changes

  1. glob
  2. update to src/tests/index.ts to match with current glob changes
  3. remove failing reset function calls.
  4. update chai and @types/chai - this is also breaking change where chai latest version @ 5.1.0 supports only ESM modules. Common JS projects has to either downgrade to 4.x.x or use dynamic imports. ex: import('chai'). Here is the reference link - @types/chai seems not to be adapted to version 5.0.0 chaijs/chai#1578 (comment)

dependabot bot and others added 16 commits January 29, 2024 18:30
@dependabot
Bump @vscode/test-electron from 2.3.8 to 2.3.9
56d656f 
Bumps [@vscode/test-electron](https://github.com/Microsoft/vscode-test) from 2.3.8 to 2.3.9.
- [Changelog](https://github.com/microsoft/vscode-test/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Microsoft/vscode-test/commits/v2.3.9)

---
updated-dependencies:
- dependency-name: "@vscode/test-electron"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump actions/checkout from 1.2.0 to 4.1.1
0d834b8 
Bumps [actions/checkout](https://github.com/actions/checkout) from 1.2.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1.2.0...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump actions/upload-artifact from 1.0.0 to 4.3.1
e219462 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1.0.0 to 4.3.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v1...5d5d22a)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump actions/setup-node from 3.8.2 to 4.0.2
bb32d84 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.2 to 4.0.2.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@1a4442c...60edb5d)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump actions/dependency-review-action from 2.5.1 to 4.1.0
d16fd4e 
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 2.5.1 to 4.1.0.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@0efb1d1...80f10bf)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@hsubramanianaks
Merge branch 'dependabot/github_actions/actions/upload-artifact-4.3.1…
c2d59fd 
…' of https://github.com/Azure/vscode-bridge-to-kubernetes into main
@hsubramanianaks
Merge branch 'dependabot/github_actions/actions/setup-node-4.0.2' of h…
1d221d7 
…ttps://github.com/Azure/vscode-bridge-to-kubernetes into main
@hsubramanianaks
Merge branch 'dependabot/github_actions/actions/dependency-review-act…
a05e0d8 
…ion-4.1.0' of https://github.com/Azure/vscode-bridge-to-kubernetes into main
@hsubramanianaks
Merge branch 'dependabot/github_actions/actions/checkout-4.1.1' of ht…
7a5a8b2 
…tps://github.com/Azure/vscode-bridge-to-kubernetes into main
@dependabot
Bump glob from 7.2.3 to 10.3.10
6cb59bb 
Bumps [glob](https://github.com/isaacs/node-glob) from 7.2.3 to 10.3.10.
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md)
- [Commits](isaacs/node-glob@v7.2.3...v10.3.10)

---
updated-dependencies:
- dependency-name: glob
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump chai from 4.3.10 to 5.1.0
2a8a94f 
Bumps [chai](https://github.com/chaijs/chai) from 4.3.10 to 5.1.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@v4.3.10...v5.1.0)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@hsubramanianaks
Merge branch 'main' of github.com:hsubramanianaks/vscode-bridge-to-ku…
7c3d44b 
…bernetes into main
@hsubramanianaks
Merge branch 'dependabot/npm_and_yarn/glob-10.3.10' of https://github…
f8032b6 
….com/Azure/vscode-bridge-to-kubernetes into group-pr-2
@hsubramanianaks
updating glob changes for test files
b81d9d4
@hsubramanianaks
bumping chai and resolving conflicts
6501f31
@hsubramanianaks
update test cases to use import method for chai
b012a17
@hsubramanianaks hsubramanianaks changed the title Glob update PR Bump glob and chai Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (91eb6a6) 73.57% compared to head (10f2430) 74.61%.

Files Patch % Lines
src/tests/suites/AccountContextManager-Test.ts 62.50% 3 Missing ⚠️
src/tests/suites/index.ts 78.57% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   73.57%   74.61%   +1.03%     
==========================================
  Files          37       37              
  Lines        3130     3313     +183     
  Branches      149      366     +217     
==========================================
+ Hits         2303     2472     +169     
- Misses        822      836      +14     
  Partials        5        5
Flag Coverage Δ
unittests 74.61% <98.41%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubramanianaks @codecov-commenter