Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #137

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Maintenance #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4e30b
Fixing new pylint complaint
rayluo Nov 25, 2024
9d372c6
Skip Python 3.7 test on ubuntu-latest
rayluo Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ jobs:
python-version: [3.7, 3.8, 3.9, "3.10", 3.11, 3.12]
os: [ubuntu-latest, windows-latest, macos-latest]
exclude: # https://github.com/actions/runner-images/issues/9770#issuecomment-2085623315
# ubuntu-latest dropped Python 3.7 since late 2024
- python-version: "3.7"
os: ubuntu-latest
# Apple Silicon ARM64 does not support Python < v3.8
- python-version: "3.7"
os: macos-latest
Expand Down
4 changes: 3 additions & 1 deletion msal_extensions/libsecret.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
class LibSecretAgent(object):
"""A loader/saver built on top of low-level libsecret"""
# Inspired by https://developer.gnome.org/libsecret/unstable/py-examples.html
def __init__( # pylint: disable=too-many-arguments
def __init__(
# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
self,
schema_name,
attributes, # {"name": "value", ...}
Expand Down
7 changes: 7 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,10 @@ passenv =

commands =
pytest

[testenv:lint]
deps =
pylint
commands =
pylint msal_extensions

Loading