Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Entra ID rebrand #6750

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Microsoft Entra ID rebrand #6750

merged 8 commits into from
Feb 8, 2024

Conversation

DidunAyodeji
Copy link
Contributor

This is the attempt to fix all the issues found in the first PR. I have run an updated script based on the feedback I got and now those issues present in the 1st PR I made have been fixed.

Updating all Azure AD terms to the Microsoft Entra ID terms in all md files.

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

What to Check

The updated changes to Microsoft Entra ID terminology make sense.

Other Information

Here's a link to the Rebrand guidelines. Note that the script doesn't have all the entries in the glossary that mine has. Let me know if you'd like to see my version of the script. https://review.learn.microsoft.com/en-us/entra/fundamentals/how-to-rename-azure-ad?branch=main

@DidunAyodeji DidunAyodeji requested a review from EmLauber December 6, 2023 00:35
@github-actions github-actions bot added documentation Related to documentation. samples Related to the samples apps for the library. labels Dec 6, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jan 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jan 4, 2024
This reverts commit 8e40f8b.
…eji/3rd-rebrand

# Conflicts:
#	samples/msal-node-samples/ElectronSystemBrowserTestApp/README.md
#	samples/msal-node-samples/auth-code-cli-app/README.md
#	samples/msal-node-samples/auth-code-cli-brokered-app/README.md
#	samples/msal-node-samples/auth-code-distributed-cache/README.md
#	samples/msal-node-samples/auth-code-key-vault/README.md
#	samples/msal-node-samples/auth-code-pkce/README.md
#	samples/msal-node-samples/auth-code-with-certs/README.md
#	samples/msal-node-samples/client-credentials-distributed-cache/README.md
#	samples/msal-node-samples/client-credentials/README.md
#	samples/msal-node-samples/custom-INetworkModule-and-network-tracing/README.md
#	samples/msal-node-samples/on-behalf-of-distributed-cache/README.md
#	samples/msal-node-samples/on-behalf-of/README.md
#	samples/msal-node-samples/refresh-token/README.md
#	samples/msal-node-samples/username-password-cca/README.md
#	samples/msal-node-samples/username-password/README.md
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-node Related to msal-node package labels Jan 18, 2024
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package msal-react Related to @azure/msal-react extensions Related to extensions for the base libraries labels Jan 18, 2024
@DidunAyodeji
Copy link
Contributor Author

I added some updates to the script so I needed to run it again on the repo. It has also been some time so I rebased my branch to be identical to the newest version of the main (dev) branch and then ran the new script.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Feb 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Feb 8, 2024
@github-actions github-actions bot removed msal-angular Related to @azure/msal-angular package msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-react Related to @azure/msal-react extensions Related to extensions for the base libraries labels Feb 8, 2024
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the updates!

@DidunAyodeji DidunAyodeji merged commit d51b97d into dev Feb 8, 2024
16 checks passed
@DidunAyodeji DidunAyodeji deleted the dayodeji/3rd-rebrand branch February 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants